remove static components, helpers, modifiers settings #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
NullVoxPopuli
approved these changes
Feb 2, 2025
mansona
force-pushed
the
staticInvokables
branch
from
ccb0096 to
f872f1c
Compare
mansona
commented
Feb 2, 2025
| @@ -145,7 +143,7 @@ Scenarios.fromProject(() => new Project()) | |||
| 'templates/application.hbs': `{{hello-world arg=1}}`, | |||
| }); | |||
|
|
|||
| await configure({ staticComponents: true }); | |||
| await configure({ staticInvokables: true }); | |||
|
|
|||
| expectTranspiled('templates/application.hbs').failsToTransform( | |||
There was a problem hiding this comment.
So this case doesn't throw an error any more 🤔 I don't know if that is expected
ef4
reviewed
Feb 4, 2025
| @@ -323,15 +320,15 @@ class TemplateResolver implements ASTPlugin { | |||
| } | |||
|
|
|||
| private get staticComponentsEnabled(): boolean { | |||
There was a problem hiding this comment.
All three of these private getters can get replaced with a single staticInvokablesEnabled
ef4
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2207
This removes the staticComponents, staticHelpers, and staticModifiers settings and throws an error if they are used