Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace random import alias with constant #94

Merged

Conversation

davidtaylorhq
Copy link
Contributor

This will make content-tag builds reproducible, which is important to avoid unnecessary cache invalidation in production. The constant alias is sufficiently complex that it's extremely unlikely to clash with real user code.

Resolves #92

This will make content-tag builds reproducible, which is important to avoid unnecessary cache invalidation in production. The constant alias is sufficiently complex that it's extremely unlikely to clash with real user code.

Resolves embroider-build#92
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NullVoxPopuli NullVoxPopuli merged commit f4d72f9 into embroider-build:main Feb 1, 2025
1 check passed
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Feb 1, 2025
@github-actions github-actions bot mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomized import name leads to non-deterministic builds
2 participants