Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release-it #323

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,6 @@ npx ember-cli@latest addon my-addon -b @embroider/addon-blueprint --addon-only

For incremental migration in monorepos, you'll want to also supply the `--skip-git` flag.

#### `--release-it`

If you want release-it behavior, (specifically provided by `create-rwjblue-release-it-setup`),
use the `--release-it` flag

```bash
npx ember-cli@latest addon my-addon -b @embroider/addon-blueprint --yarn --release-it
```

#### `--typescript`

Sets up the new addon with [`typescript`](https://www.typescriptlang.org/) support.
Expand Down
14 changes: 0 additions & 14 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const fs = require('fs-extra');
const SilentError = require('silent-error');
const sortPackageJson = require('sort-package-json');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
const execa = require('execa');
const { merge } = require('lodash');
const { lt } = require('semver');

Expand Down Expand Up @@ -97,10 +96,6 @@ module.exports = {
if (isPnpm(options)) {
tasks.push(pnpm.createWorkspacesFile(options.target, addonInfo, testAppInfo));
}

if (options.releaseIt) {
tasks.push(this.setupReleaseIt(options.target));
}
}

await Promise.all(tasks);
Expand Down Expand Up @@ -239,14 +234,6 @@ module.exports = {
await fs.remove(overridesPath);
},

async setupReleaseIt(rootPath) {
await execa('create-rwjblue-release-it-setup', ['--no-install'], {
cwd: rootPath,
preferLocal: true,
localDir: __dirname,
});
},

fileMapTokens(options) {
let { addonInfo, testAppInfo, ext } = options.locals;

Expand Down Expand Up @@ -299,7 +286,6 @@ module.exports = {
[`--ci-provider=${options.ciProvider}`]: options.ciProvider,
'--pnpm': isPnpm(options),
'--npm': isNpm(options),
'--release-it': options.releaseIt,
[`--test-app-location=${options.testAppLocation}`]: options.testAppLocation,
[`--test-app-name=${options.testAppName}`]: options.testAppName,
'--typescript': options.typescript,
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"ember-cli": "^5.6.0",
"ember-cli-normalize-entity-name": "^1.0.0",
"ember-cli-string-utils": "^1.1.0",
"execa": "^5.1.1",
"fs-extra": "^10.0.0",
"lodash": "^4.17.21",
"semver": "^7.3.8",
Expand Down
Loading
Loading