-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document addon release process #61
Comments
Note that we support a That doesn't mean we cannot or should not provide instructions for the manual case. But unless there are good reasons to not use this setup, I would recommend that one over any manual steps! |
Aha TIL about If I want to generate new addon (and I don't know the steps from the top of my head), I'd go:
So maybe first step would be to improve the documentation at cli.emberjs.com? Trying to confirm & that I'm not doing something silly here. Second thing, and I know that's heavily subjective so putting it more as a question, would be that I would recommend having a system to help with releasing v2 addon by default? I don't really care if it's npm script or |
So, all the documentation links and
Yeah, but that will be basically be one thing the RFC will need to suggest. So that's not going to happen that soon... And yes, this blueprint adds a few non-standard CLI options like
I am open for discussing that. As a matter of fact, the release setup was once added by default, when there was no way to opt-in or -out of it. After the |
I think there are two more release strategies we should add as options -- which I think strengthens the argument to have none enabled by default? The two I'd like to add are:
Update, I've been moving all my stuff (including ember-resources) over to Changesets, because semantic-release has too many caveats and rough edges around monorepos, and I wanted something that "just worked" |
I've completely 180'd on this, as I consider release strategy separate from project blueprints. While having a release strategy is important, and folks should know how to do it -- it's not a concern of ember (these tools work everywhere, basically). We absolutely should still document some stuff on the guides -- and we need a lot more addon docs on the guides anyway ... as there are basically none. I removed release-it from this blueprint here: #323 For automated releases, the embroider/tooling team now has a "release from anywhere" tool, which can be setup in one command: We also don't need to maintain any code here 🎉 |
Releasing v2 addon is not entirely trivial, so would be good to have a way to tell folks how to do this.
Given that people might prefer variety of tools (yarn / npm / ...) it might be a good idea to document this in *.md file, so that people can follow & adapt.
Proposal:
The text was updated successfully, but these errors were encountered: