[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882
Conversation
|
@NullVoxPopuli @kategengler I restored the non-modifer parts of the modifier source file. All lints and tests and checks pass locally. I am not sure how much of that very old event dispatcher code is in use anymore. Maybe "send" or some other old event mechanism still hits that code path. |
|
While we deprecated and remove the action modifier and helper we didn't deprecate or remove the |
|
In a post- QUnit.test('Should not attempt to render element modifiers GH#14220', function (assert) {
assert.expect(1);
this.template('application', "<div {{action 'foo'}}></div>");
return this.renderToHTML('/').then(function (html) {
assert.htmlMatches(html, '<body><div></div></body>');
});
});From app-boot-test.js |
We could replace action with |
I believe this a FastBoot test that is verifying that a modifier that adds something to the DOM doesn't do it in the FastBoot context. For |
Related to #20816.
The cleanup for this deprecation is pretty substantial, as it completely deletes two longstanding pieces of code from the resolver: the action modifier and the action helper. One consequence of this is that
actionis no longer a built-in keyword and can presumably be used now like any other helper and modifier.