Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Re-add support for moduleResolution=node10 #20877

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

VM PR: glimmerjs/glimmer-vm#1741

Text from that PR Description:

This feels crazy to add support for the node10 moduleResolution setting, but as pointed out in:
#20876

Some projects aren't up to date enough to use more modern moduleResolution settings -- and every TS dep needs to be compat with both in order to allow a consumer to migrate.

From the tsconfig docs

Default: Node10 if module is CommonJS; Node16 if module is Node16 or Node18; NodeNext if module is NodeNext; Bundler if module is Preserve; Classic otherwise.

No one should be using Node10 if they're writing ESM.

moduleResolution: node was renamed to moduleResolution: node10 with the release of TypeScript 5.0, which was released in March of 2023, which at the time, ember LTS was 4.8 with 4.12 being released on May 2023.

So it is within the TS Rolling support policy to be reasonable to have dropped support for moduleResolution: node10, and earlier TS versions.
(assuming config changes't aren't covered under semver-ts -- I opened this issue on semver-ts)

However, supporting node10 is easy, as this PR is one line change in each published package.json

Verified

This commit was signed with the committer’s verified signature.
@ef4 ef4 merged commit 63f6f4e into emberjs:main Mar 20, 2025
27 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/re-add-support-for-moduleResolution=node10 branch March 20, 2025 18:12
@ef4
Copy link
Contributor

ef4 commented Mar 20, 2025

@kategengler can we get a new beta that includes this?

@kategengler kategengler changed the title Re-add support for moduleResolution=node10 [BUGFIX beta] Re-add support for moduleResolution=node10 Mar 20, 2025
@kategengler
Copy link
Member

@ef4 Is it urgent or is the regularly schedule beta on Monday okay?

@ef4
Copy link
Contributor

ef4 commented Mar 20, 2025

Regularly scheduled is fine, just wanted to make sure it gets into some beta. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants