-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ember-showdown-shiki #902
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4bf8cfc
install showdown and prism
mansona 4fddccb
use markdown-to-html for all descriptions
mansona c87af01
WIP ⚠️ use markdown branch
mansona 183b27d
make import-example use the same code block as markdown
mansona 43ab518
remove custom highlighting styles
mansona 24d35cd
update prember
mansona cf5daf8
switch to ember-cli-shiki
mansona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1 @@ | ||
<div class='highlight javascript'> | ||
<div class='ribbon'></div> | ||
{{#if (is-clipboard-supported)}} | ||
<div class='import-copy'> | ||
{{#if this.showClipboardSuccessIcon}} | ||
{{svg-jar 'success' width='24px' height='24px'}} | ||
{{else}} | ||
<CopyButton @clipboardText={{concat 'import ' @item " from '" @package "';"}} @title='Copy to clipboard' @success={{this.showSuccess}}> | ||
{{svg-jar 'copy' width='24px' height='24px'}} | ||
</CopyButton> | ||
{{/if}} | ||
</div> | ||
{{/if}} | ||
<table class='CodeRay'> | ||
<tbody> | ||
<tr> | ||
<td class='code'><pre><span class='wrapper'><span class='keyword'>import</span> {{@item}} <span class='keyword'>from</span> <span class='string'>'{{@package}}'</span>;</span></pre></td> | ||
</tr> | ||
</tbody> | ||
</table> | ||
</div> | ||
<MarkdownToHtml @markdown={{this.markdown}} /> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
import { action } from '@ember/object'; | ||
import Component from '@glimmer/component'; | ||
import { later } from '@ember/runloop'; | ||
import { tracked } from '@glimmer/tracking'; | ||
|
||
export default class ImportExample extends Component { | ||
@tracked showClipboardSuccessIcon = false; | ||
|
||
@action | ||
showSuccess() { | ||
this.showClipboardSuccessIcon = true; | ||
later(this, () => (this.showClipboardSuccessIcon = false), 950); | ||
get markdown() { | ||
let md = `\`\`\`js | ||
import ${this.args.item} from '${this.args.package}'; | ||
\`\`\``; | ||
return md; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
module.exports = function () { | ||
return { | ||
buildSandboxGlobals(defaultGlobals) { | ||
return Object.assign({}, defaultGlobals, { | ||
atob: atob, | ||
}); | ||
}, | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: interesting, wasn't aware we had this functionality in the API docs. Could be something to build into
ember-showdown-shiki
😄