Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add FaithDialRetrieval dataset #874

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

vaibhavad
Copy link
Contributor

@vaibhavad vaibhavad commented Jun 3, 2024

Checklist for adding MMTEB dataset

Reason for dataset addition:

  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

@vaibhavad vaibhavad marked this pull request as ready for review June 3, 2024 23:09
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor thins - otherwise I believe it looks good!

docs/mmteb/points/874.jsonl Show resolved Hide resolved
mteb/tasks/Retrieval/eng/FaithDialRetrieval.py Outdated Show resolved Hide resolved
mteb/tasks/Retrieval/eng/FaithDialRetrieval.py Outdated Show resolved Hide resolved
mteb/tasks/Retrieval/eng/FaithDialRetrieval.py Outdated Show resolved Hide resolved
mteb/tasks/Retrieval/eng/FaithDialRetrieval.py Outdated Show resolved Hide resolved
@isaac-chung isaac-chung changed the title Faithdial fix: Add FaithDialRetrieval dataset Jun 4, 2024
vaibhavad and others added 6 commits June 4, 2024 19:40
Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>
Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>
@vaibhavad vaibhavad merged commit 582381b into embeddings-benchmark:main Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants