Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add JMTEB Clustering datasets #768

Merged
merged 6 commits into from
May 20, 2024

Conversation

awinml
Copy link
Contributor

@awinml awinml commented May 20, 2024

Checklist for adding MMTEB dataset

Part of #749

Changes Made:

Adds the Livedoor News and MewsC-16-ja datasets from JMTEB.


  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

@awinml awinml mentioned this pull request May 20, 2024
Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this. Can add points for review as well.

@isaac-chung isaac-chung self-assigned this May 20, 2024
@isaac-chung isaac-chung enabled auto-merge (squash) May 20, 2024 11:18
@isaac-chung isaac-chung merged commit 970b03c into embeddings-benchmark:main May 20, 2024
7 checks passed
dokato pushed a commit to dokato/mteb that referenced this pull request May 24, 2024
* Add JMTEB Clustering datasets
* Add points
* Add points for review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants