Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mieb] Fill out gme v and jina clip model meta #1887

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

isaac-chung
Copy link
Collaborator

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

@isaac-chung isaac-chung requested a review from Samoed January 28, 2025 09:58
mteb/models/gme_v_models.py Outdated Show resolved Hide resolved
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
@isaac-chung isaac-chung merged commit e8b2256 into mieb Jan 28, 2025
11 checks passed
@isaac-chung isaac-chung deleted the fill-out-gme_v-and-jina_clip-model-meta branch January 28, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants