Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix jina v1, 2 models #1872

Merged
merged 1 commit into from
Jan 26, 2025
Merged

fix: fix jina v1, 2 models #1872

merged 1 commit into from
Jan 26, 2025

Conversation

Samoed
Copy link
Collaborator

@Samoed Samoed commented Jan 25, 2025

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
BIOSSES
Model card 80.51
main 55.5422
PR 80.4832

Closing #1862

Samoed
Samoed commented Jan 25, 2025
View reviewed changes
mteb/models/lens_models.py
Comment on lines -3 to -9
from functools import partial

import torch

from mteb.encoder_interface import PromptType
from mteb.model_meta import ModelMeta, sentence_transformers_loader
from mteb.models.instruct_wrapper import instruct_wrapper
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff removed these lines

@Samoed Samoed merged commit 1d66089 into main Jan 26, 2025
11 checks passed
@Samoed Samoed deleted the fix_jina_models branch January 26, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung approved these changes

@x-tabdeveloping x-tabdeveloping Awaiting requested review from x-tabdeveloping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samoed @isaac-chung