Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Leaderboard] Autocalculate memory usage in model meta #1935

Open
Tracked by #1867
Samoed opened this issue Feb 2, 2025 · 2 comments
Open
Tracked by #1867

[Leaderboard] Autocalculate memory usage in model meta #1935

Samoed opened this issue Feb 2, 2025 · 2 comments
Labels
enhancement New feature or request leaderboard issues related to the leaderboard

Comments

@Samoed
Copy link
Collaborator

Samoed commented Feb 2, 2025 •
edited by isaac-chung
Loading

To make the new leaderboard fully compatible with the old one, we can add memory usage tracking. I’ve added a property for this in #1934 . This includes auto-calculating the usage in FP32 and reporting the number in GB.
@Samoed Samoed added enhancement New feature or request leaderboard issues related to the leaderboard labels Feb 2, 2025
@Samoed Samoed mentioned this issue Feb 3, 2025
Merged
4 tasks
@isaac-chung
Copy link
Collaborator

@Samoed FYI I updated the title to fully cover the scope of your PR. Wish we added this sooner!

@isaac-chung isaac-chung changed the title [Leaderboard] Add memory usage [Leaderboard] Autocalculate memory usage in model meta Feb 3, 2025
@Samoed
Copy link
Collaborator Author

Samoed commented Feb 3, 2025

@x-tabdeveloping What do you think?

This was referenced Feb 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request leaderboard issues related to the leaderboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Samoed @isaac-chung