Skip to content

embassy-boot: remove default features from embassy-embedded-hal #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomasbarton-stemcell
Copy link
Contributor

@tomasbarton-stemcell tomasbarton-stemcell commented Apr 16, 2025

embassy-embedded-hal enables the time feature by default, which will require you to include the time driver if you use any of the functions that use it (for example spi::blocking::transaction), otherwise the binary fails to link.

@Dirbaio
Copy link
Member

Dirbaio commented Apr 16, 2025

I'd prefer to make the time feature not default. Default features are a footgun precisely because this reason, too easy to forgot to disable them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants