Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation.json for French translation #16

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

Ekaekale
Copy link
Contributor

@Ekaekale Ekaekale commented Apr 8, 2020

Solves: #8

locales/fr/translation.json Outdated Show resolved Hide resolved
locales/fr/translation.json Show resolved Hide resolved
@elxris
Copy link
Owner

elxris commented Apr 8, 2020

I'm adding a new feature. Could we wait a little for this?

@elxris
Copy link
Owner

elxris commented Apr 8, 2020

I have pushed the new feature. We can continue. Thank you for your patience!

@elxris
Copy link
Owner

elxris commented Apr 8, 2020

Please review 1.3 changes, and I have added "Guaranteed Min", "guaranteedMinInfo" and "changelog1.4"

@elxris
Copy link
Owner

elxris commented Apr 8, 2020

I will push 1.4 with this translation missing. Just to deliver some other features! But as soon as this is ready I will deploy them. Thank you! ❤️

@elxris elxris added the WIP Work in progress label Apr 8, 2020
@elxris
Copy link
Owner

elxris commented Apr 8, 2020

I'm adding a Work in Progress label. Please remove it when it's done! Thank you!

Copy link
Contributor

@Noelierx Noelierx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some new translations.

locales/fr/translation.json Outdated Show resolved Hide resolved
locales/fr/translation.json Outdated Show resolved Hide resolved
locales/fr/translation.json Outdated Show resolved Hide resolved
locales/fr/translation.json Outdated Show resolved Hide resolved
@Ekaekale
Copy link
Contributor Author

Ekaekale commented Apr 8, 2020

@Noelierx Je ne suis pas très dégourdi avec l'utilisation de Github, j'espère avoir fait ce qu'il fallait pour ajouter vos traductions aux miennes ! Si ce n'est pas le cas, pouvez-vous m'aider afin de résoudre cela le plus rapidement possible ? Merci ! :)

Co-Authored-By: Noëlie <noelieroux11@gmail.com>
@elxris elxris removed the WIP Work in progress label Apr 8, 2020
@elxris elxris merged commit e22ee43 into elxris:master Apr 8, 2020
@elxris
Copy link
Owner

elxris commented Apr 8, 2020

Thank you! #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants