Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metainfo: Fix appstreamcli validate warnings #45

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

ryonakano
Copy link
Contributor

This fixes some warnings from appstreamcli validate command which I noticed while reviewing your app. This is just a warning and not a critical error, so you don't need to publish another release soon after merging this.

Before

[ryo@b760m ~/work/tmp/Jorts (main $=)]$ appstreamcli validate data/jorts.metainfo.xml.in
I: io.github.ellie_commons.jorts:10: description-first-para-too-short
     Colourful little sticky notes for all of your thoughts :)
W: io.github.ellie_commons.jorts:29: url-not-reachable
     https://github.com/ellie_commons/jorts - URL was not found on the server.
W: io.github.ellie_commons.jorts:30: url-not-reachable
     https://github.com/ellie_commons/jorts/issues - URL was not found on the server.
W: io.github.ellie_commons.jorts:31: url-not-reachable
     https://github.com/ellie_commons/jorts/issues - URL was not found on the server.
W: io.github.ellie_commons.jorts:32: url-not-reachable
     https://github.com/ellie_commons/jorts/blob/main/po/README.md - URL was not found on the
     server.
W: io.github.ellie_commons.jorts:67: tag-empty translation

✘ Validation failed: warnings: 5, infos: 1
[ryo@b760m ~/work/tmp/Jorts (main $=)]$

After

[ryo@b760m ~/work/tmp/Jorts (ryonakano/fix-metainfo-warnings)]$ appstreamcli validate data/jorts.metainfo.xml.in
I: io.github.ellie_commons.jorts:10: description-first-para-too-short
     Colourful little sticky notes for all of your thoughts :)

✔ Validation was successful: infos: 1
[ryo@b760m ~/work/tmp/Jorts (ryonakano/fix-metainfo-warnings)]$

Fixes the following warnings from "appstreamcli validate" command:

- url-not-reachable
- tag-empty translation
@ryonakano ryonakano requested a review from teamcons March 9, 2025 13:01
@teamcons
Copy link
Collaborator

teamcons commented Mar 9, 2025

Thank you

@teamcons teamcons merged commit 9050d2c into main Mar 9, 2025
@ryonakano ryonakano deleted the ryonakano/fix-metainfo-warnings branch March 9, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants