Fix geneanet occupation #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nationalization in French and more
…se, generates an error -
remove extra 's'
…ower than 1600 except for curators: 1000 - import of occupations from geneanet.
Allow control of GENI profiles
GuyKh
reviewed
Feb 21, 2025
| @@ -122,7 +122,7 @@ function parseFindAGrave(htmlstring, familymembers, relation) { | |||
| } | |||
| } | |||
| } | |||
| profiledata = addEvent(profiledata, "burial", parsed.find("#burialDateLabel").text(), cemetery.trim()); | |||
| profiledata = addEvent(profiledata, "burial", convDateFrench(parsed.find("#burialDateLabel").text()), cemetery.trim()); | |||
There was a problem hiding this comment.
Why to convert all dates to frenchDates?
GuyKh
reviewed
Feb 21, 2025
| @@ -282,6 +282,7 @@ function addEvent(profiledata, event, dateval, eventlocation) { | |||
| } | |||
| dateval = cleanDate(dateval); | |||
| if (dateval !== "unknown" && dateval !== "") { | |||
| convDateFrench(dateval); | |||
There was a problem hiding this comment.
This is very tailored for French
|
A. Need to resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very poorly structured Geneanet html pages, detecting a possible profession is quite difficult. So it makes sense that dirty html generates dirty Javascript...
The standalone addition (no need for modification elsewhere) of code is located from the //jobs comment.