-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow eliza client to configure eliza server base URL via env var #3589
feat: allow eliza client to configure eliza server base URL via env var #3589
Conversation
Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bguiz! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
- NOTE that usage of SERVER_PORT was not yet documented, so also added that adjacent Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>
Great, thanks @odilitime ! |
…ar (elizaOS#3589) * feat: allow eliza client to configure eliza server base URL via env var Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> * docs: add how to use SERVER_BASE_URL in local developement docs page - NOTE that usage of SERVER_PORT was not yet documented, so also added that adjacent Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> * fix syntax issue --------- Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> Co-authored-by: Odilitime <janesmith@airmail.cc>
…ar (elizaOS#3589) * feat: allow eliza client to configure eliza server base URL via env var Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> * docs: add how to use SERVER_BASE_URL in local developement docs page - NOTE that usage of SERVER_PORT was not yet documented, so also added that adjacent Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> * fix syntax issue --------- Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com> Co-authored-by: Odilitime <janesmith@airmail.cc>
Relates to
Risks
Background
What does this PR do?
What kind of change is this?
Why are we doing this? Any context or related work?
Documentation changes needed?
SERVER_BASE_URL
) but also an existing thing (SERVER_PORT
) which wasn't yet documentedTesting
Straight forward, manual testing
Test case (1)
On own machine:
On own machine as well:
SERVER_BASE_URL="http://localhost:4567" pnpm start:client
Test case (2)
On hosted machine, served at
foobar.my.custom.domain
:On hosted machine, served at
barfoo.my.custom.domain
:SERVER_BASE_URL="https://foobar.my.custom.domain:80" pnpm start:client
Where should a reviewer start?
.
Detailed testing steps
Discord username
bguiz