feat: external test #2205
feat: external test #2205
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @eCoxvague! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
|
Sorry, but provide more information about this PR. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| async function runProcess(command, args = [], directory = projectRoot()) { | ||
| try { | ||
| throw new Error("Not implemented yet"); | ||
| // TODO | ||
| // const result = await $`cd ${directory} && ${command} ${args}`; | ||
| return result.stdout.trim(); | ||
| } catch (error) { | ||
| throw new Error(`Command failed: ${error.message}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
The runProcess function currently throws immediately and contains unreachable code. Consider implementing process execution using either spawn() or exec() from the child_process module instead of the commented template literal syntax. Here's an example:
const result = await spawn(command, args, { cwd: directory });This would provide proper process handling and output capture.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
Hello, We are changing our plugin development strategy to be more scalable. We have moved the plugins out into their own repos and we're looking for people to either maintain those or own them on their own Github. If you'd like to be a maintainer, file an issue in the plugin repo and join our Discord https://discord.gg/elizaos to coordinate. If you'd like to control the plugin on your own Github, please add an issue to the plugin repo pointing to your repo, and add a modification to the registry. Submit a PR to edit the registry here: https://github.com/elizaos-plugins/registry Closing this PR for now. Let us know if you have any questions. |
Fix
Relates to
Risks
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps