-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Integration Tests Enhancement and Coinbase Commerce Integration #1767
Merged
monilpat
merged 18 commits into
elizaOS:develop
from
Sifchain:piotr/coinbase-plugin-tests
Jan 10, 2025
Merged
test: Integration Tests Enhancement and Coinbase Commerce Integration #1767
monilpat
merged 18 commits into
elizaOS:develop
from
Sifchain:piotr/coinbase-plugin-tests
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test1.mjs
Outdated
// Verify charge creation response | ||
const chargeResponse = response[1]; | ||
assert(chargeResponse.text.startsWith("Charge created successfully:"), "Should indicate successful charge creation"); | ||
assert(chargeResponse.text.includes("https://commerce.coinbase.com/pay/"), "Should contain valid Coinbase Commerce URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
' ' can be anywhere in the URL, and arbitrary hosts may come before or after it.
https://commerce.coinbase.com/pay/
Error loading related location
Loading
tests/test1.mjs
Outdated
assert(attachment.url, "Should have a charge ID URL"); | ||
assert(attachment.description.startsWith("Charge ID:"), "Should have charge ID description"); | ||
assert(attachment.text.startsWith("Pay here:"), "Should have payment URL"); | ||
assert(attachment.text.includes("https://commerce.coinbase.com/pay/"), "Should have valid Coinbase Commerce URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
' ' can be anywhere in the URL, and arbitrary hosts may come before or after it.
https://commerce.coinbase.com/pay/
Error loading related location
Loading
monilpat
approved these changes
Jan 10, 2025
0xpi-ai
pushed a commit
to 0xpi-ai/NayariAI
that referenced
this pull request
Jan 15, 2025
…ests test: Integration Tests Enhancement and Coinbase Commerce Integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration Tests Enhancement and Coinbase Commerce Integration
Changes
Integration Tests Framework
send()
function to return full response data instead of just textCoinbase Commerce Integration
getChargeDetails
by adding missing slashTest Coverage
CI/CD
Testing
The PR includes extensive integration tests that verify:
Tests can be run locally with:
Note: Tests require valid
OPENAI_API_KEY
andCOINBASE_COMMERCE_KEY
environment variables to be set.Dependencies