-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bridge and swap actions context params generation #1524
base: develop
Are you sure you want to change the base?
Conversation
I think there's some duplication of the work done in #1456 but I did my best to merge the best of both |
This pull request has been automatically marked as stale due to 30 days of inactivity. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Relates to:
issue number #1523
Risks
Medium: Changes on two files created compose actions & regenerate the details object
Background
What does this PR do?
This fix ensures that the bridge and swap actions are properly populated with the necessary details required for the bridgeAction and SwapAction handlers. As a result:
Bridge operations will now process the toAddress, token information, and other required parameters without error.
Swap operations will execute successfully with all required data passed to the handler.