Fix PR comments

Author: ppsimatikas

packages/plugin-xtreamly/__tests__/actions/retrieveVolatilityState.test.ts

@@ -63,6 +63,7 @@ describe('retrieveVolatilityPrediction', () => {
     describe('validation', () => {
         it('should validate successfully when API is up and running', async () => {
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve({ status: 'ok' }),
             });
             const result = await retrieveVolatilityState.validate(mockRuntime, mockMessage);
@@ -71,6 +72,7 @@ describe('retrieveVolatilityPrediction', () => {
 
         it('should fail validation when API is down', async () => {
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve({ status: 'down' }),
             });
             const result = await retrieveVolatilityState.validate(mockRuntime, mockMessage);
@@ -97,6 +99,7 @@ describe('retrieveVolatilityPrediction', () => {
             const mockFormattedResponse = mockVolatilityState.classification_description;
 
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve(mockVolatilityState),
             });
 

packages/plugin-xtreamly/__tests__/libs/VolatilityAPI.test.ts

@@ -42,6 +42,7 @@ describe('VolatilityAPI library', () => {
                 volatility: 0.111,
             };
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve(mockResponse),
             });
 
@@ -65,6 +66,7 @@ describe('VolatilityAPI library', () => {
                 },
             ];
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve(mockResponse),
             });
 
@@ -94,6 +96,7 @@ describe('VolatilityAPI library', () => {
                 classification_description: 'This is midvol',
             };
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve(mockResponse),
             });
 
@@ -118,6 +121,7 @@ describe('VolatilityAPI library', () => {
                 },
             ];
             mockFetch.mockResolvedValueOnce({
+                ok: true,
                 json: () => Promise.resolve(mockResponse),
             });
 

packages/plugin-xtreamly/src/libs/VolatilityAPI.ts

@@ -36,7 +36,7 @@ export class VolatilityAPI extends XtreamlyAPI {
         startDate: Date,
         endDate: Date,
         symbol = 'ETH'
-    ): Promise<VolatilityPrediction[]> {
+    ): Promise<StatePrediction[]> {
         return this.get(XtreamlyAPIPath.stateHistorical, {
             symbol,
             start_date: startDate.getTime(),

packages/plugin-xtreamly/src/libs/XtreamlyAPI.ts

@@ -38,7 +38,12 @@ export class XtreamlyAPI {
         return fetch(url.toString(), {
             method: 'GET',
             headers: this.headers,
-        }).then((res) => res.json());
+        }).then(async (res) => {
+            if (!res.ok) {
+                throw new Error(`HTTP error! status: ${res.status}`);
+            }
+            return res.json();
+        });
     }
 
     async is_ok(): Promise<boolean> {