Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tests against all supported nx versions #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: tests against all supported nx versions #10

wants to merge 2 commits into from

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented May 22, 2024

No description provided.

@grzuy
Copy link
Contributor Author

grzuy commented May 22, 2024 •
edited
Loading

Failure because nx 0.5 didn't yet had Nx.to_tensor working to traverse lazy container. Not until 0.6 (elixir-nx/nx@fca5f6d).

I guess we could adapt test to work for that, but given docs also recommend using Nx.to_tensor to eveluate lazy Safetensors.FileTensor results returned by read! probably better to just drop support for nx 0.5. Thoughts?

Adding new commit soon.

@grzuy grzuy force-pushed the test-nx-versions branch from 62cd8d3 to 7dc5d46 Compare May 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grzuy