Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convolutions #22

Merged
merged 76 commits into from
Dec 24, 2024
Merged

Convolutions #22

merged 76 commits into from
Dec 24, 2024

Conversation

hunterboerner
Copy link
Contributor

@hunterboerner hunterboerner commented Dec 9, 2024 •
edited
Loading

Todo:

  • FFT method "mode" switch
  • Fix broken test for "valid" configuration

hunterboerner and others added 23 commits December 7, 2024 12:47
@hunterboerner
add first convolution test
f220c47
@hunterboerner
stub implementation
e30062b
@hunterboerner
add assert_all_close helper
c4de7cb
@hunterboerner
Attempt at implementing convolve
b8599f5
@hunterboerner
Add another test
597d2ce
@hunterboerner
remove nil
b32169c
@hunterboerner
try changing order
db61498
@hunterboerner
shape to output
4388184
@hunterboerner
change reversing
8de0a00
@hunterboerner
full mode
67ae6f3
@hunterboerner
proper reshaping
c0cf107
@hunterboerner
Add another test
c317373
@hunterboerner
Complex test
8ab92ab 
Apparently we don't want to get the complex conjugate
@hunterboerner
Zero rank
219de78
@hunterboerner
Add a numpy test
60864fa
@hunterboerner
fairly unnecessary unwrite test
e5e1856
@hunterboerner
Add comment for where tests came from
d4028c6
@hunterboerner
Add auto mode
e502373
@hunterboerner
Start implementing fftconvolve
61cf708
@polvalente
refactor: simplify reshapes and fix paddings
5cef02b
@polvalente
Merge branch 'convolutions' of github.com:hunterboerner/nx_signal int…
12ac3c7 
…o convolutions
@hunterboerner
No auto method
de67b3a
@hunterboerner
We have FFT support but the tensors are not ordered correctly
1d849ff
hunterboerner and others added 4 commits December 21, 2024 22:10
@hunterboerner @polvalente
Update lib/nx_signal/convolution.ex
4596b30 
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@hunterboerner @polvalente
Update lib/nx_signal/convolution.ex
bfbb807 
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@hunterboerner @polvalente
Update lib/nx_signal/convolution.ex
910c4ba 
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@hunterboerner @polvalente
Update lib/nx_signal/convolution.ex
09a6817 
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@polvalente polvalente merged commit 6465f93 into elixir-nx:main Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunterboerner @polvalente