Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: schema export #2081

Merged
merged 1 commit into from
Mar 23, 2025
Merged

refactor: schema export #2081

merged 1 commit into from
Mar 23, 2025

Conversation

jo-elimu
Copy link
Member

@jo-elimu jo-elimu commented Mar 23, 2025

Relates to:

Issue Number

Purpose

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Mar 23, 2025
@jo-elimu jo-elimu requested a review from a team as a code owner March 23, 2025 14:13
@jo-elimu jo-elimu requested review from AshishBagdane, nya-elimu and tomaszsmy and removed request for a team March 23, 2025 14:13
@jo-elimu jo-elimu linked an issue Mar 23, 2025 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (7a19320) to head (ce51b5c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2081   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
  Complexity      401      401           
=========================================
  Files           240      240           
  Lines          6671     6671           
  Branches        748      748           
=========================================
  Hits           1011     1011           
  Misses         5610     5610           
  Partials         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

coderabbitai bot commented Mar 23, 2025

Walkthrough

This pull request updates the dependency configuration and database migration script. The pom-dependency-tree.txt file now reflects an updated version for the ai.elimu:webapp dependency along with the addition of a new model dependency and its transitive dependencies. In parallel, several audio-related tables and their foreign key constraints have been removed from the JPA schema export SQL file.

Changes

File Change Summary
pom-dependency-tree.txt Updated ai.elimu:webapp from 2.5.56-SNAPSHOT to 2.5.57-SNAPSHOT and added new dependency com.github.elimu-ai:model:jar:model-2.0.85:compile with its transitive dependencies.
src/.../jpa-schema-export.sql Removed SQL definitions for audio-related tables (Audio, Audio_Letter, Audio_literacySkills, Audio_Number, Audio_numeracySkills, Audio_Word) and associated foreign keys.

Assessment against linked issues

Objective Addressed Explanation
Remove Audio from application code (frontend & ORM entities) [#1944] Frontend and ORM entity removals are not included.
Prepare database migration script (drop audio-related tables) [#1944]

Possibly related PRs

Suggested reviewers

  • jpatel3
  • AshishBagdane
  • vrudas

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3336477 and ce51b5c.

📒 Files selected for processing (2)
  • pom-dependency-tree.txt (1 hunks)
  • src/main/resources/META-INF/jpa-schema-export.sql (0 hunks)
💤 Files with no reviewable changes (1)
  • src/main/resources/META-INF/jpa-schema-export.sql
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: build (ubuntu-latest, 17)
  • GitHub Check: build (macos-latest, 21)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: build (ubuntu-latest, 21)
  • GitHub Check: build (macos-latest, 17)
  • GitHub Check: test_rest_localhost
🔇 Additional comments (2)
pom-dependency-tree.txt (2)

1-1: Version Update Verification
The version for ai.elimu:webapp:war has been updated to 2.5.57-SNAPSHOT. Please confirm that this new version is fully compatible with all downstream modules and that any necessary regression tests have been run.


2-4: Review New Dependency Addition
A new dependency com.github.elimu-ai:model:jar:model-2.0.85 has been added along with its transitive dependencies (gson:2.11.0 and error_prone_annotations:2.27.0). Please verify that these versions align with the project’s requirements and do not introduce any conflicts with existing dependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jo-elimu jo-elimu merged commit cf379c6 into main Mar 23, 2025
10 checks passed
@jo-elimu jo-elimu deleted the 1944-schema-export branch March 23, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Audio entity
1 participant