Skip to content

Commit

Permalink
+ better name
Browse files Browse the repository at this point in the history
  • Loading branch information
q3769 committed Mar 20, 2024
1 parent 8ad4a17 commit 9ee97fa
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/main/java/elf4j/engine/NativeLogServiceProvider.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import elf4j.engine.service.NativeLogServiceManager;
import elf4j.engine.service.NativeLoggerService;
import elf4j.engine.service.configuration.LogServiceConfiguration;
import elf4j.engine.service.util.StackTraceUtils;
import elf4j.engine.service.util.StackTraces;
import elf4j.spi.LogServiceProvider;
import java.util.EnumSet;
import java.util.Map;
Expand Down Expand Up @@ -97,7 +97,7 @@ public NativeLogServiceProvider(@NonNull Class<?> serviceAccessClass) {
@Override
public NativeLogger logger() {
return getLogger(
defaultLoggerLevel, StackTraceUtils.callerOf(serviceAccessClass).getClassName());
defaultLoggerLevel, StackTraces.callerOf(serviceAccessClass).getClassName());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import elf4j.engine.NativeLogger;
import elf4j.engine.service.configuration.LogServiceConfiguration;
import elf4j.engine.service.configuration.LoggerOutputLevelThreshold;
import elf4j.engine.service.util.StackTraceUtils;
import elf4j.engine.service.util.StackTraces;
import elf4j.engine.service.writer.GroupWriter;
import elf4j.engine.service.writer.LogWriter;
import elf4j.util.IeLogger;
Expand Down Expand Up @@ -94,7 +94,7 @@ public void log(
.serviceInterfaceClass(serviceInterfaceClass)
.callerFrame(
includeCallerDetail()
? LogEvent.StackFrameValue.from(StackTraceUtils.getCallerFrame(
? LogEvent.StackFrameValue.from(StackTraces.getCallerFrame(
serviceInterfaceClass, new Throwable().getStackTrace()))
: null)
.build());
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/elf4j/engine/service/pattern/JsonElement.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import com.dslplatform.json.PrettifyOutputStream;
import com.dslplatform.json.runtime.Settings;
import elf4j.engine.service.LogEvent;
import elf4j.engine.service.util.StackTraceUtils;
import elf4j.engine.service.util.StackTraces;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStream;
Expand Down Expand Up @@ -133,7 +133,7 @@ static JsonLogEntry from(@NonNull LogEvent logEvent, @NonNull JsonElement jsonPa
.exception(
logEvent.getThrowable() == null
? null
: StackTraceUtils.getTraceAsBuffer(logEvent.getThrowable()))
: StackTraces.getTraceAsBuffer(logEvent.getThrowable()))
.build();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
package elf4j.engine.service.pattern;

import elf4j.engine.service.LogEvent;
import elf4j.engine.service.util.StackTraceUtils;
import elf4j.engine.service.util.StackTraces;
import lombok.NonNull;
import lombok.Value;

Expand All @@ -45,6 +45,6 @@ public void render(@NonNull LogEvent logEvent, @NonNull StringBuilder target) {
if (t == null) {
return;
}
target.append(System.lineSeparator()).append(StackTraceUtils.getTraceAsBuffer(t));
target.append(System.lineSeparator()).append(StackTraces.getTraceAsBuffer(t));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
import lombok.NonNull;

/** */
public class StackTraceUtils {
private StackTraceUtils() {}
public class StackTraces {
private StackTraces() {}

/**
* @param calleeClass whose caller is being searched for
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;

class StackTraceUtilsTest {
class StackTracesTest {

@Nested
class getCallerFrame {
@Test
void whenCalleeClassIsNotFoundInCallStack() {
assertThrows(
NoSuchElementException.class,
() -> StackTraceUtils.getCallerFrame(NotInCallstack.class, new Throwable().getStackTrace()));
() -> StackTraces.getCallerFrame(NotInCallstack.class, new Throwable().getStackTrace()));
}

class NotInCallstack {}
Expand Down

0 comments on commit 9ee97fa

Please sign in to comment.