Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher: use dbus to log out #819

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Launcher: use dbus to log out #819

merged 2 commits into from
Oct 1, 2024

Conversation

danirabbit
Copy link
Member

Fixes #806

confirmed that this command works on latest RC

@danirabbit danirabbit requested a review from a team September 30, 2024 21:48
@meisenzahl meisenzahl merged commit 82c0b40 into main Oct 1, 2024
5 checks passed
@meisenzahl meisenzahl deleted the danirabbit-patch-1 branch October 1, 2024 04:09
@ryonakano
Copy link
Member

@danirabbit

confirmed that this command works on latest RC

How did you confirmed this? Calling the dbus-send in the live session does nothing for me……

VirtualBox_test_01_10_2024_21_23_54

@meisenzahl
Copy link
Member

I have to admit that I have not tested this in an installer session. I am sorry.

meisenzahl added a commit that referenced this pull request Oct 1, 2024
@danirabbit
Copy link
Member Author

@ryonakano I tested it in demo mode yesterday just like that. Dunno why that didn't work for you 🤔

@ryonakano
Copy link
Member

Hmm, after I trigger the logout dialog from Wingpanel, both gnome-session-quit and dbus-send began to work as expected:

Screencast.from.2024-10-01.23-36-25.mp4

@danirabbit
Copy link
Member Author

I just booted the latest daily and it does show the log out dialog here when clicking the installer launcher

@meisenzahl
Copy link
Member

I have tested the behavior with elementaryos-8.0-daily.20241003.iso and elementaryos-8.0-daily.20241004.iso. Unfortunately, I cannot confirm that the behavior works as desired.

My behavior is the same as @ryonakano's.

However, when I enter gnome-session logout in Terminal, I am immediately logged out without a dialog. Can you confirm this behavior? Could this be the right command?

@ryonakano
Copy link
Member

However, when I enter gnome-session logout in Terminal, I am immediately logged out without a dialog. Can you confirm this behavior? Could this be the right command?

I can confirm that behavior, but on OS 7 the logout dialog is prompt before actual logout

@leolost2605
Copy link
Member

Just FYI gnome-session-quit --no-prompt will log out instantly without going the route via the session manager and therefore wingpanel or anything. If all else fails this might be the most robust way.
At least that's how it works in the normal session not sure whether anything changes here but I guess it shouldn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Installer doesn't launch from Applications menu in Circe daily
4 participants