X11: Use window shape to fix input for invisible windows #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38778eb.
leolost2605
force-pushed
the
leolost/xshape
branch
3 times, most recently
from
02e2cb2 to
55b914b
Compare
leolost2605
force-pushed
the
leolost/xshape
branch
from
55b914b to
8f0d29c
Compare
lenemter
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit just reverts #2122
Rebase merge
Fixes the same issue as #2122 and is already prepared to be used as intended in #2134. Since it doesn't move anything we don't run into issues of having to solve conflicts between e.g. window positioner and the hidden window, as well as not having to have an additional class handle coordinates etc. which is IMHO quite a bit cleaner.
Closes #2134