Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon: Implement monitor labels #1861

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Daemon: Implement monitor labels #1861

merged 3 commits into from
Feb 19, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 18, 2024

Taken from #1840 (was easier than rebase :))

Fixes #1823

For the switchboard side see elementary/switchboard-plug-display#372

@leolost2605 leolost2605 requested a review from a team February 18, 2024 13:41
@lenemter
Copy link
Member

I'm not sure if window title is a good way to do this. I remember #1427 was rejected for this reason. @tintou how should gala identify gala-daemon windows?

@lenemter lenemter requested a review from tintou February 19, 2024 10:02
@leolost2605
Copy link
Member Author

Yeah I wasn't sure either but I think the difference to #1427 is that we already know for sure that it's a daemon window and only differentiate between different types of daemon windows 🤷

@tintou
Copy link
Member

tintou commented Feb 19, 2024

Note that handle_daemon_window won't be called on X11 so we need another wrapper for X11, maybe by just ensuring that ("%" + uint64.FORMAT).format (window.get_pid ()) == subprocess.get_identifier ().
I think that this is good enough for a first iteration, ideally the daemon should communicate each type of window with a dedicated DBus signal, but that would probably be better to iterate on it so that we can move faster.

@leolost2605
Copy link
Member Author

leolost2605 commented Feb 19, 2024

Note that handle_daemon_window won't be called on X11 so we need another wrapper for X11, maybe by just ensuring that ("%" + uint64.FORMAT).format (window.get_pid ()) == subprocess.get_identifier ().

Since the daemon is still GTK3 I've just used the GTK3 methods for positioning etc. for X11

@danirabbit danirabbit merged commit bf4eec8 into master Feb 19, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/monitor-labels branch February 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API for display labels
4 participants