Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sound confirmations in the wingpanel indicator #1816

Closed
wants to merge 1 commit into from

Conversation

lenemter
Copy link
Member

No description provided.

@Marukesu
Copy link
Contributor

The way i would go with this is disabling the volume-* keybindings in GSD, and handling they in the sound indicator.

We already expose the org.gnome.Shell.GrabAccelerators method in gala, there's no need for creating a new DBus interface.

@lenemter
Copy link
Member Author

@Marukesu there is #1724 with your proposal. I'd like to revisit it later separately.

We already expose the org.gnome.Shell.GrabAccelerators method in gala, there's no need for creating a new DBus interface.

Yes, but we need to trigger sound change feedback in the indicator, so we can't use org.gnome.Shell.GrabAccelerators since it's exposed by gala, not the indicator. Or you meant something different?

@Marukesu
Copy link
Contributor

We already expose the org.gnome.Shell.GrabAccelerators method in gala, there's no need for creating a new DBus interface.

Yes, but we need to trigger sound change feedback in the indicator, so we can't use org.gnome.Shell.GrabAccelerators since it's exposed by gala, not the indicator. Or you meant something different?

I mean, make the indicator call org.gnome.Shell.GrabAccelerators, and handle both the volume change and the feedback, so instead of this:

  GSD -> GrabAccelerators -> gala -> AcceleratorActivated -> GSD -> ShowOSD -> gala -> HandleOSD -> sound indicator.

we have this:

  sound indicator -> GrabAccelerators -> gala -> AcceleratorActivated -> sound indicator

@lenemter lenemter removed the request for review from danirabbit December 31, 2023 09:17
@lenemter
Copy link
Member Author

Closing in favour of elementary/wingpanel-indicator-sound#270.

@lenemter lenemter closed this Dec 31, 2023
@lenemter lenemter deleted the sound-media-feedback branch December 31, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants