Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "BackgroundManager: Don't position background actors" #1814

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Revert "BackgroundManager: Don't position background actors" #1814

merged 1 commit into from
Dec 27, 2023

Conversation

lenemter
Copy link
Member

Reverts #1809
Fixes #1813

This code is necessary after all :(

@lenemter lenemter requested a review from leolost2605 December 26, 2023 17:04
leolost2605
leolost2605 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the grey background issue for me 🥳
The two grey strips still appear and now also on the desktop but i guess that's a different issue so i'll open another one for that 🤷

@lenemter lenemter merged commit fe1918d into master Dec 27, 2023
4 checks passed
@lenemter lenemter deleted the revert-1809-lenemter/remove-control-position branch December 27, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary monitor grey background
2 participants
@lenemter @leolost2605