Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundManager: Don't position background actors #1809

Merged
merged 3 commits into from
Dec 18, 2023
Merged

BackgroundManager: Don't position background actors #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2629cb2
BackgroundManager: Inline namespace
lenemter Dec 17, 2023
8a6dd54
BackgroundManager: Don't position background actors
lenemter Dec 17, 2023
63e0480
Merge branch 'master' into lenemter/remove-control-position
lenemter Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Background/BackgroundManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup {

public WindowManager wm { get; construct; }
public int monitor_index { get; construct; }
public bool control_position { get; construct; }

private BackgroundSource background_source;
private Meta.BackgroundActor background_actor;
private Meta.BackgroundActor? new_background_actor = null;

public BackgroundManager (WindowManager wm, int monitor_index, bool control_position = true) {
Object (wm: wm, monitor_index: monitor_index, control_position: control_position);
public BackgroundManager (WindowManager wm, int monitor_index) {
Object (wm: wm, monitor_index: monitor_index);
}

construct {
Expand Down Expand Up @@ -128,10 +127,6 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup {
var monitor = display.get_monitor_geometry (monitor_index);
background_actor.set_size (monitor.width, monitor.height);

if (control_position) {
background_actor.set_position (monitor.x, monitor.y);
}

ulong changed_handler = 0;
changed_handler = background.changed.connect (() => {
background.disconnect (changed_handler);
Expand Down
2 changes: 1 addition & 1 deletion src/Widgets/MonitorClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace Gala {
construct {
reactive = true;

background = new BackgroundManager (wm, monitor, false);
background = new BackgroundManager (wm, monitor);

var scale = display.get_monitor_scale (monitor);

Expand Down
3 changes: 1 addition & 2 deletions src/Widgets/WorkspaceClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ namespace Gala {
public FramedBackground (WindowManager wm) {
Object (
wm: wm,
monitor_index: wm.get_display ().get_primary_monitor (),
control_position: false
monitor_index: wm.get_display ().get_primary_monitor ()
);
}

Expand Down