Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundManager: Don't position background actors #1809

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

lenemter
Copy link
Member

Branch based on #1808

This code seems to be unnecessary.

@danirabbit
Copy link
Member

It looks like this was introduced in 2014 as part of supporting the mutter version at that time, so it's very possible it's not needed anymore. It looks like there is an instance of BackgroundManager in src/Background/BackgroundContainer.vala that wasn't setting control_position to false though

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any issues here though, so let's go! Easy enough to revert if a problem appears

@danirabbit danirabbit merged commit a4a3fa5 into master Dec 18, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/remove-control-position branch December 18, 2023 19:01
lenemter added a commit that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants