Renamer: Avoid listbox get_children #2564
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no more
ListBox.get_children ()
in GTK4There's one place I didn't replace here and it's the block starting at line 154. I suppose we could iterate over the list and add to a counter to get the number of children? Alternatively if we switched this whole thing to use a ListModel we could get the number of items in the model, but we'd need to add a "new_name" property to
Files.File
. Thoughts @jeremypw?