Simple syntax changes #2553
Open
Simple syntax changes #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Mar 19, 2025
Co-authored-by: Danielle Foré <danielle@elementary.io>
danirabbit
requested changes
Mar 21, 2025
|
Sorry - I overlooked dialogs need to be shown whereas other widgets you can just delete |
|
I have pushed another PR applying the dialog fixes to the main branch where possible. |
danirabbit
requested changes
Mar 23, 2025
Comment on lines
+157
to
+165
| var grid = new Gtk.Box (VERTICAL, 0); | ||
|
|
||
| grid.append (header); | ||
| grid.append (new Gtk.Separator (Gtk.Orientation.HORIZONTAL)); | ||
| grid.append (chooser); | ||
| grid.append (new Gtk.Separator (Gtk.Orientation.HORIZONTAL)); | ||
| grid.append (choices_box); | ||
| // grid.append (action_box); | ||
| child = grid; |
There was a problem hiding this comment.
While we're here, can we rename this to box since it isn't a grid anymore :p
| @@ -11,22 +11,19 @@ public class PortalTester : Gtk.Application { | |||
| window.set_default_size (400, 400); | |||
| window.title = "Files Portal Tester"; | |||
|
|
|||
| var grid = new Gtk.Grid () { | |||
| var grid = new Gtk.Box (VERTICAL, 6) { | |||
There was a problem hiding this comment.
We removed Portaltester in another branch so I guess this needs to be rebased?
| // content_box.pack_start (overlay, true, true, 0); | ||
| // overlay.add (widget); | ||
| overlay = new Gtk.Overlay () { | ||
| child = widget |
There was a problem hiding this comment.
pack_start had true for expand so I think we need to add hexpand = true and vexpand = true
|
|
||
| sidebar = new Sidebar.SidebarWindow (); | ||
| free_space_change.connect (sidebar.on_free_space_change); | ||
|
|
||
| lside_pane = new Gtk.Paned (Gtk.Orientation.HORIZONTAL) { | ||
| // expand = true, | ||
| hexpand = true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted simple changes mainly to accomodate changes in syntax. These changes should not have any functional effect.