Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WindowSystem #363

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Introduce WindowSystem #363

merged 4 commits into from
Feb 14, 2025

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Feb 13, 2025

Reducing diff of #361

Changes:

  1. AppWindow -> Window since this object stores info about opened window, it is not AppSystem specific.
  2. Introduces WindowSystem that communicates with DesktopIntegration and syncs internal list of Window objects. Then AppSystem (and WorkspaceSystem in the future) can use this list to update apps' list of windows etc.

@lenemter lenemter requested a review from a team February 13, 2025 19:01
@alainm23
Copy link

alainm23 commented Feb 13, 2025

I'm not sure what the best Git workflow would be in this case, but at my workplace, for a new feature, we create a new branch derived from main, for example, feat/workspace-switcher. We then submit PRs little by little to that branch. Once everything is okay and tested, we submit a PR to main. I mention this because you might make more adjustments and changes for this new feature. What do you think @danirabbit?

@danirabbit
Copy link
Member

Personally I prefer this way of merging in smaller more reviewable chunks. It's easier on reviewers and I think we're more likely to catch things as we go than trying to merge in one huge branch

@lenemter lenemter merged commit 43aaf3c into main Feb 14, 2025
4 checks passed
@lenemter lenemter deleted the lenemter/introduce-window-system branch February 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants