Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher: Pin app on drag #294

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Launcher: Pin app on drag #294

merged 3 commits into from
Oct 14, 2024

Conversation

leolost2605
Copy link
Member

Fixes #289

@leolost2605 leolost2605 requested a review from a team October 13, 2024 21:36
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely works but it also makes it so you can't drag an app off of the dock to unpin it 😂

@danirabbit danirabbit dismissed their stale review October 14, 2024 19:47

Actually I'm having this issue in main too. Something else with my install maybe

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly on a (relatively) clean install. Nice job :)

@danirabbit danirabbit merged commit 26cd2bb into main Oct 14, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/pin-on-drag branch October 14, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag running app to pin
2 participants