Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New room list: hide favourites and people meta spaces #29241

Merged
merged 3 commits into from
Feb 13, 2025
Merged

New room list: hide favourites and people meta spaces #29241

merged 3 commits into from
Feb 13, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 11, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task https://github.com/element-hq/wat-internal/issues/204
When the new room list labs flag is enabled:

  • Hide the Favourites and People meta spaces in the left panel
  • Hide the related buttons in the settings and in the quick settings
  • Add some extra space in the quick settings between the remaining buttons

@florianduros florianduros force-pushed the florianduros/new-room-list/hide-favourite-people-meta-space branch from b3a3410 to 7d19bfb Compare February 11, 2025 15:43
@florianduros florianduros force-pushed the florianduros/new-room-list/hide-favourite-people-meta-space branch 2 times, most recently from 7271eeb to af335ad Compare February 11, 2025 15:48
@florianduros florianduros force-pushed the florianduros/new-room-list/hide-favourite-people-meta-space branch from af335ad to 9b1e71a Compare February 11, 2025 16:27
Base automatically changed from midhun/new-room-list/create-labs-flag to develop February 12, 2025 12:14
@florianduros florianduros force-pushed the florianduros/new-room-list/hide-favourite-people-meta-space branch from 03f7f1c to 9d4db1c Compare February 12, 2025 12:24
@florianduros florianduros force-pushed the florianduros/new-room-list/hide-favourite-people-meta-space branch from 9d4db1c to 92f8246 Compare February 12, 2025 12:29
@florianduros florianduros marked this pull request as ready for review February 12, 2025 12:56
@florianduros florianduros requested a review from a team as a code owner February 12, 2025 12:56
@florianduros florianduros added this pull request to the merge queue Feb 13, 2025
Merged via the queue into develop with commit 4b9382f Feb 13, 2025
42 checks passed
@florianduros florianduros deleted the florianduros/new-room-list/hide-favourite-people-meta-space branch February 13, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @MidhunSureshR