Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom annotation to the map. #29223

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

toshanmugaraj
Copy link

Encrypt the annotations and store in the room state.
Use the pinned message as the password to encrypt and decrypt.
Delete annotation in the map.
Choose annotation color and description while marking.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • [x ] Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Encrypt the annotations and store in the room state.
Use the pinned message as the password to encrypt and decrypt.
Delete annotation in the map.
Choose annotation color and description while marking.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 10, 2025
@toshanmugaraj toshanmugaraj requested a review from a team as a code owner February 10, 2025 06:39
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, first of all thanks for the contribution!

According to the location sharing spec, we don't support custom annotation.We mustn't use pinned message to store this kind of data.

Also, you should read the code style guide before contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants