Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeyIcon to key storage out of sync toast #29201

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Add KeyIcon to key storage out of sync toast #29201

merged 2 commits into from
Feb 5, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 5, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Figma design

Before After
image image

@florianduros florianduros changed the title feat(toast crypto): add KeyIcon to key storage out of sync toast Add KeyIcon to key storage out of sync toast Feb 5, 2025
@florianduros florianduros force-pushed the florianduros/add-key-icon-toast-out-of-sync branch from be196a8 to 5b71aed Compare February 5, 2025 14:42
@florianduros florianduros force-pushed the florianduros/add-key-icon-toast-out-of-sync branch from 54cd997 to b4dcd30 Compare February 5, 2025 15:00
@florianduros florianduros marked this pull request as ready for review February 5, 2025 15:15
@florianduros florianduros requested a review from a team as a code owner February 5, 2025 15:15
@florianduros florianduros added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@florianduros florianduros added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit 0358b7f Feb 5, 2025
37 checks passed
@florianduros florianduros deleted the florianduros/add-key-icon-toast-out-of-sync branch February 5, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy