Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport staging] Wire up the "Forgot recovery key" button for the "Key storage out of sync" toast #29190

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[Backport staging] Wire up the "Forgot recovery key" button for the "Key storage out of sync" toast #29190

wants to merge 1 commit into from

Conversation

RiotRobot
Copy link
Contributor

Backport 9657d39 from #29138.

@dbkr @github-actions
Wire up the "Forgot recovery key" button for the "Key storage out of …
159acef 
…sync" toast (#29138)

* Wire up the "Forgot recovery key" button for the "Key storage out of sync" toast

* Unused import & fix test

* Test 'forgot' variant

* Fix dependencies

* Add more toast tests

* Unused import

* Test initialState in Encryption Tab

* Let's see if github has any more luck running this test than me

* Working playwright test with screenshot

* year

* Convert playwright test to use the bot client

* Disambiguate

Co-authored-by: Florian Duros <florianduros@element.io>

* Add doc & do other part of rename

* Split out into custom hook

* Fix tests

---------

Co-authored-by: Florian Duros <florianduros@element.io>
(cherry picked from commit 9657d39)
@RiotRobot RiotRobot requested a review from a team as a code owner February 4, 2025 18:04
@RiotRobot RiotRobot requested a review from a team as a code owner February 4, 2025 18:04
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 4, 2025
richvdh
richvdh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a backport, but I have some comments on the original PR, which looks like it only got a cursory review.

richvdh
richvdh requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button

richvdh
richvdh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum it's good enough for a backport

@t3chguy t3chguy added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect X-Release-Blocker Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiotRobot @richvdh @dbkr