Stop showing a dialog prompting the user to enter an old recovery key #29143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/dehydrated_no_reprompt_security_key
branch
from
9716dec to
09d745d
Compare
richvdh
force-pushed
the
rav/dehydrated_no_reprompt_security_key
branch
from
09d745d to
a45a1c9
Compare
We don't really support the concept of having multiple 4S keys active, so prompting the user to enter a non-default 4S key without even telling them which one we want is rather silly.
We seem to already have about 5 copies of this code, so before I add another, let's factor it out.
This should be fixed by the previous commit, so let's check it stays that way.
richvdh
force-pushed
the
rav/dehydrated_no_reprompt_security_key
branch
from
a45a1c9 to
dbd3417
Compare
|
oops, my bad. Now fixed. |
MidhunSureshR
approved these changes
Jan 30, 2025
andybalaam
requested review from
andybalaam
and removed request for
BillCarsonFr
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we need a secret that is stored in 4S under an old recovery key, we put up a modal prompting the user to enter that old key, but don't actually tell them which key it is we are after.
Our design doesn't really support having more than one recovery key at a time -- we tell our users that there is only one recovery key.
So, it's better to treat such secrets as non-existent, rather than bothering the user for access.
Fixes: #29130.
Suggest review commit-by-commit.