Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #29139

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update Dockerfile #29139

wants to merge 1 commit into from

Conversation

SergeyDjam
Copy link

change ELEMENT_WEB_PORT 80 to 8080. For fix start container in podman and docker rootless.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

change ELEMENT_WEB_PORT 80 to 8080. For fix start container in podman and docker rootless.
@SergeyDjam SergeyDjam requested a review from a team as a code owner January 29, 2025 20:24
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 29, 2025
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break backwards compatibility in a non-obvious way as all existing functional containers in Docker would break without any error. Vs podman and other quasi-supported environments needing to specify a variable. This is not desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants