Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn self change on roles settings #28926

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: warn self change on roles settings #28926

wants to merge 1 commit into from

Conversation

MarcWadai
Copy link

@MarcWadai MarcWadai commented Jan 8, 2025 •
edited
Loading

closes #26297

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@MarcWadai MarcWadai requested a review from a team as a code owner January 8, 2025 11:43
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 8, 2025
@florianduros florianduros requested a review from a team January 9, 2025 15:16
florianduros
florianduros reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Lets ask product their opinion on it.

@MidhunSureshR MidhunSureshR added the X-Needs-Product More input needed from the Product team label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros left review comments

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Enhancement X-Needs-Product More input needed from the Product team Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission Settings Don't Protect Against Self-Changes
4 participants
@MarcWadai @CLAassistant @florianduros @MidhunSureshR