Skip to content

Don't crash the build when trying to docker-package from a shallow clone of a commit #28503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Nov 20, 2024

wearing a Nordeck hat - I hope the source branch is sufficient to auth that fact.

Pending clarification how to handle CLA between Nordeck and Element. Corporate CLA signed, see source branch.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@HarHarLinks HarHarLinks requested a review from a team as a code owner November 20, 2024 15:52
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@florianduros florianduros removed their request for review December 24, 2024 14:48
@richvdh
Copy link
Member

richvdh commented Jan 30, 2025

Hi @HarHarLinks,

Pending clarification how to handle CLA between Nordeck and Element.

Any progress on getting that clarification?

@HarHarLinks
Copy link
Contributor Author

@neilisfragile is on it

@HarHarLinks
Copy link
Contributor Author

Corporate CLA is signed and sent to Element.

@t3chguy
Copy link
Member

t3chguy commented Apr 2, 2025

Can you pull latest develop to hopefully kick the CLA bot into life

@HarHarLinks HarHarLinks force-pushed the HarHarLinks/fix-shallow-downstream-builds branch from e71c988 to 81419d7 Compare April 2, 2025 07:46
@t3chguy
Copy link
Member

t3chguy commented Apr 2, 2025

Ah so the CLA doesn't approve based on the CLA Nordeck signed as you are not a member of @nordeck publicly

This organization has no public members.

Will raise this with compliance who are responsible for the CLA

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Apr 9, 2025

Is this CLA different from the synapse (element-hq/synapse#18286) and EC (element-hq/element-call#3178) ones? CLAassistant made me sign again.

@t3chguy
Copy link
Member

t3chguy commented Apr 10, 2025

I do believe that cla-assisstant is a per-repo thing unfortunately

image

image

Repos are linked one-by-one rather than an org-level thing which would make far more sense.

@t3chguy t3chguy added this pull request to the merge queue Apr 10, 2025
@HarHarLinks
Copy link
Contributor Author

And yet, signing the CLA for element-call was enough to also have signed for synapse.

@t3chguy
Copy link
Member

t3chguy commented Apr 10, 2025

Unfortunately i have no access to look at the configuration for CLA Assistant for those repos, it'd be a question for legal/compliance.

Merged via the queue into element-hq:develop with commit afc8536 Apr 10, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants