-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Don't crash the build when trying to docker-package from a shallow clone of a commit #28503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash the build when trying to docker-package from a shallow clone of a commit #28503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane
Hi @HarHarLinks,
Any progress on getting that clarification? |
@neilisfragile is on it |
Corporate CLA is signed and sent to Element. |
0ca1b4d
to
e71c988
Compare
Can you pull latest develop to hopefully kick the CLA bot into life |
e71c988
to
81419d7
Compare
Ah so the CLA doesn't approve based on the CLA Nordeck signed as you are not a member of @nordeck publicly
Will raise this with compliance who are responsible for the CLA |
81419d7
to
ce599eb
Compare
Is this CLA different from the synapse (element-hq/synapse#18286) and EC (element-hq/element-call#3178) ones? CLAassistant made me sign again. |
And yet, signing the CLA for element-call was enough to also have signed for synapse. |
Unfortunately i have no access to look at the configuration for CLA Assistant for those repos, it'd be a question for legal/compliance. |
wearing a Nordeck hat - I hope the source branch is sufficient to auth that fact.
Pending clarification how to handle CLA between Nordeck and Element.Corporate CLA signed, see source branch.Checklist
public
/exported
symbols have accurate TSDoc documentation.