rfc: Corner Smoothing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaddock
added
the
pending-review
|
I've opened a PR for the reference implementation of this RFC: electron/electron#45185 |
|
Looks like the brilliant folks working on Flutter are also working in this problem space! flutter/engine#56726 Might see if we can join forces and land some of this work at the Skia level. |
erickzhao
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
LGTM
We reviewed this API together with @clavin in a synchronous API working group meeting last week.
Some conclusions from the meeting:
- Adding the
electronvendor prefix to the CSS property is good enough to mark it as experimental/nonstandard. - The final implementation PR should address whether or not the new property should be available on macOS only be default, or on all systems. It may be a pain point for users to need to turn off the rule only on Windows/Linux if they only want this prop enabled on macOS. CSS doesn't have a way to apply rules only on specific operating systems.
samuelmaddock
approved these changes
Jan 22, 2025
|
|
||
| The `-electron-corner-smoothing` CSS rule controls how much of the edge can be used for corner curvature: | ||
| * It is a percentage between `0%` (default) and `100%`. The value `100%` represents maximum smoothing, but may not consume the full edge. | ||
| * The keyword `system-ui` can be used to pick a value that matches the current OS UI. |
erickzhao
added
final-comment-period
and removed
pending-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying
border-radiusto an element makes its corners circular. This proposal adds "smoother" round corners, controlled by a prefixed CSS property. Applications can use this feature to further integrate with macOS's design language, or simply for aesthetic purposes.📄 Read rendered document