Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar covering tabs #16

Open
jokob-sk opened this issue Jun 8, 2024 · 8 comments
Open

Scrollbar covering tabs #16

jokob-sk opened this issue Jun 8, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@jokob-sk
Copy link

jokob-sk commented Jun 8, 2024

electerm-web Version and download file extension(electerm-web版本和下载文件后缀)

2.39.18

Platform detail (平台详情)

docker x86

What steps will reproduce the bug?(重新问题的详细步骤)

Open any tab

What should have happened?(期望的结果)

The tab name shouldn't be covered by a scrollbar

Would this happen in other terminal app(是否能够在其他同类软件重现这个问题)

No response

Additional information(其他任何相关信息)

image

@zxdong262 zxdong262 added the bug Something isn't working label Jun 8, 2024
@zxdong262
Copy link
Member

What is the browser and browser version?

@jokob-sk
Copy link
Author

jokob-sk commented Jun 8, 2024 via email

@zxdong262
Copy link
Member

zxdong262 commented Jun 8, 2024

I see, it is browser compatibality issue, any webkit browser should works fine, I may add a warning that only support webkit browser in next release, thank you for the feeback.

@jokob-sk
Copy link
Author

jokob-sk commented Jun 8, 2024

Would be nice if this could be fixed also for FF (it's an overflow scroll as seen in the screeshot), but I understand how hard it is to support multiple browsers. Anyway - I'll probably still use it on FF since it's a great productivity boost :) All the best!

image

@zxdong262
Copy link
Member

Would be nice if this could be fixed also for FF (it's an overflow scroll as seen in the screeshot), but I understand how hard it is to support multiple browsers. Anyway - I'll probably still use it on FF since it's a great productivity boost :) All the best!

image

Sure, let me do something about it

@zxdong262
Copy link
Member

Did some research, copilot tells me that as of late 2018, Firefox introduced limited scrollbar customization options using the scrollbar-width property. Unfortunately, there’s no direct equivalent to ::-webkit-scrollbar, so seems can not control the scrollbar width easily.

zxdong262 added a commit that referenced this issue Jun 8, 2024
@zxdong262
Copy link
Member

Updated, just set scollx to hidden, not a pefect solution, there would some place have similar issue, at least not that obvious as tabs

@jokob-sk
Copy link
Author

jokob-sk commented Jun 8, 2024

🙏thanks a lot for the fix. Yes, I couldn't find any other big issues and this will improve the feel of the app quite a bit, even with limited FF support. I know how hard it is sometimes to fully test and support things (https://github.com/jokob-sk/NetAlertX) 😅 Good luck with the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants