Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning refactor #27

Merged
merged 8 commits into from
Jan 26, 2025
Merged

Versioning refactor #27

merged 8 commits into from
Jan 26, 2025

Conversation

hazzuk
Copy link
Member

@hazzuk hazzuk commented Jan 24, 2025

Currently the apps versioning is partly based on element-web, and static values have to be manually updated for a release. This PR does the following to address this:

  • change the package.json app version to elecord
  • dynamically display the app version in the auth page footer
  • remove elecord's static version number from settings
  • shorten version numbers to 7 chars (matching github's format)
  • use git tags as version on release builds
  • always use the sha for the last commit made

@hazzuk hazzuk added the enhancement New feature or request label Jan 24, 2025
@hazzuk hazzuk force-pushed the versioning-refactor branch from 1232a25 to 9028a54 Compare January 24, 2025 22:17
@hazzuk hazzuk force-pushed the versioning-refactor branch from 9028a54 to 8b6f583 Compare January 24, 2025 22:37
@hazzuk hazzuk force-pushed the versioning-refactor branch from 2220a00 to c77a3c6 Compare January 25, 2025 03:29
@hazzuk
Copy link
Member Author

hazzuk commented Jan 25, 2025

  • - fix builds not using correct git rev-parse for elecord
  • - test release version tag usage

For pull requests, GitHub Actions checks out the repo by simulating a merge commit of the PR. But we always want the SHA of the last commit, not the simulated merge commit.
Copy link

Cloudflare Pages deployment

Latest commit 77d5ba9c4ca88175e34a225f87be62c8dcccac38
Status ✅ Deployed!
URL https://cf90c481.elecord-web.pages.dev

@hazzuk hazzuk merged commit 9d3a294 into master Jan 26, 2025
2 checks passed
@hazzuk hazzuk deleted the versioning-refactor branch January 26, 2025 00:26
@hazzuk hazzuk restored the versioning-refactor branch January 28, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant