From 1323ac854c5f0e32343c0f1a51b67e3afef1c395 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Wed, 11 Dec 2024 22:47:33 +0000 Subject: [PATCH 01/11] feat(index): tweak meta theme colour --- src/vector/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vector/index.html b/src/vector/index.html index a2b80a61324..e1ccf65e099 100644 --- a/src/vector/index.html +++ b/src/vector/index.html @@ -21,7 +21,7 @@ - + > $GITHUB_STEP_SUMMARY # Update PR status comment with deployment URL - name: Update status comment (Failure) From 8f4e02d52849d1c8deeca7dc2c43e09ea9f683b9 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Thu, 12 Dec 2024 15:29:35 +0000 Subject: [PATCH 05/11] feat(config): update config values From element-web documentation --- config.json | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/config.json b/config.json index f26c0613f0b..0b8a35e02c5 100644 --- a/config.json +++ b/config.json @@ -1,5 +1,4 @@ { - "default_server_name": "matrix.org", "default_server_config": { "m.homeserver": { "base_url": "https://matrix-client.matrix.org" @@ -18,8 +17,6 @@ "https://scalar-staging.vector.im/api", "https://scalar-staging.riot.im/scalar/api" ], - "bug_report_endpoint_url": "https://element.io/bugreports/submit", - "uisi_autorageshake_app": "element-auto-uisi", "show_labs_settings": false, "room_directory": { "servers": ["matrix.org", "gitter.im"] @@ -40,14 +37,32 @@ ], "privacy_policy_url": "https://element.io/cookie-policy", "setting_defaults": { - "RustCrypto.staged_rollout_percent": 100 + "RustCrypto.staged_rollout_percent": 100, + "fontSizeDelta": 2, + "use_system_theme": false, + "showRedactions": false, + "showTwelveHourTimestamps": true, + "urlPreviewsEnabled_e2ee": true, + "Spaces.showPeopleInSpace": false, + "videoInputMuted": true, + "useOnlyCurrentProfiles": true }, "features": { "feature_video_rooms": true, "feature_group_calls": true, - "feature_element_call_video_rooms": true + "feature_element_call_video_rooms": true, + "feature_pinning": true, + "feature_custom_themes": true, + "feature_html_topic": true }, "element_call": { - "url": "https://call.element.io" + "url": "https://call.element.io", + "use_exclusively": true, + "brand": "Elecord Voice" + }, + "default_theme": "dark", + "disable_3pid_login": true, + "embedded_pages": { + "login_for_welcome": true } } \ No newline at end of file From 0ab3496f283e30b74bd52817fa2da04b92eb1181 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Thu, 12 Dec 2024 15:59:40 +0000 Subject: [PATCH 06/11] chore(github): refactor deployment url --- .github/workflows/build.yml | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4462942aea3..0218d7091e9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -93,12 +93,15 @@ jobs: echo "cf_branch=test" >> $GITHUB_ENV elif [[ "${{ github.event.pull_request.base.ref }}" == "release" ]]; then echo "cf_branch=preview" >> $GITHUB_ENV + echo "cf_domain=https://preview.elecord.app / " >> $GITHUB_ENV fi elif [[ "${{ github.event_name }}" == "push" ]]; then if [[ "${{ github.ref_name }}" == "master" ]]; then echo "cf_branch=dev" >> $GITHUB_ENV + echo "cf_domain=https://dev.elecord.app / " >> $GITHUB_ENV elif [[ "${{ github.ref_name }}" == "release" ]]; then echo "cf_branch=release" >> $GITHUB_ENV + echo "cf_domain=https://web.elecord.app / " >> $GITHUB_ENV fi fi @@ -110,11 +113,6 @@ jobs: apiToken: ${{ secrets.CLOUDFLARE_PAGES_API_TOKEN }} accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} command: pages deploy dist --project-name=elecord-web --branch=${{ env.cf_branch }} - - - name: Deployment URL - if: ${{ steps.cf.outputs.deployment-url != '' }} - run: | - echo "Deployed to ${{ steps.cf.outputs.deployment-url }}" >> $GITHUB_STEP_SUMMARY # Update PR status comment with deployment URL - name: Update status comment (Failure) @@ -133,13 +131,6 @@ jobs: reactions: -1 mode: recreate - # When deploying to the preview branch, add the preview URL - - name: Add preview URL - run: | - if [[ "${{ env.cf_branch }}" == "preview" ]]; then - echo -e "cf_preview=https://preview.elecord.app / " >> $GITHUB_ENV - fi - - name: Update status comment (Success) if: ${{ github.event_name == 'pull_request' && success() }} uses: thollander/actions-comment-pull-request@v3 @@ -150,8 +141,13 @@ jobs: | **Latest commit** | ${{ github.event.pull_request.head.sha || github.sha }} | |-------------------|:-:| | **Status** | ✅ Deployed! | - | **URL** | ${{ env.cf_preview }}${{ steps.cf.outputs.deployment-url != '' && steps.cf.outputs.deployment-url || 'Not available' }} | + | **URL** | ${{ env.cf_domain }}${{ steps.cf.outputs.deployment-url != '' && steps.cf.outputs.deployment-url || 'Not available' }} | pr-number: ${{ github.event.pull_request.number }} comment-tag: CFPages-deployment reactions: rocket - mode: recreate \ No newline at end of file + mode: recreate + + - name: Add URL to summary + if: ${{ steps.cf.outputs.deployment-url != '' }} + run: | + echo "${{ env.cf_domain }}${{ steps.cf.outputs.deployment-url }}" >> $GITHUB_STEP_SUMMARY From cbabdfb367fcb9bdbad1f5db6043fd1ee56d2ab1 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Thu, 12 Dec 2024 16:44:20 +0000 Subject: [PATCH 07/11] fix(config): correct config values --- config.json | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/config.json b/config.json index 0b8a35e02c5..f7a72ebc799 100644 --- a/config.json +++ b/config.json @@ -1,7 +1,7 @@ { "default_server_config": { "m.homeserver": { - "base_url": "https://matrix-client.matrix.org" + "base_url": "https://matrix.org" }, "m.identity_server": { "base_url": "https://vector.im" @@ -38,30 +38,28 @@ "privacy_policy_url": "https://element.io/cookie-policy", "setting_defaults": { "RustCrypto.staged_rollout_percent": 100, - "fontSizeDelta": 2, + "baseFontSizeV2": "18", "use_system_theme": false, "showRedactions": false, "showTwelveHourTimestamps": true, "urlPreviewsEnabled_e2ee": true, - "Spaces.showPeopleInSpace": false, - "videoInputMuted": true, "useOnlyCurrentProfiles": true }, "features": { "feature_video_rooms": true, "feature_group_calls": true, "feature_element_call_video_rooms": true, - "feature_pinning": true, "feature_custom_themes": true, "feature_html_topic": true }, "element_call": { "url": "https://call.element.io", - "use_exclusively": true, - "brand": "Elecord Voice" + "use_exclusively": true }, "default_theme": "dark", "disable_3pid_login": true, + "disable_guests": true, + "force_verification": true, "embedded_pages": { "login_for_welcome": true } From 07e03d734db8f8e2741258de1289759454307c19 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Fri, 13 Dec 2024 13:18:00 +0000 Subject: [PATCH 08/11] feat(backdrop): hide background profile blur In Element, the users profile is used as the blurred background colour. --- res/css/structures/_BackdropPanel.pcss | 1 + 1 file changed, 1 insertion(+) diff --git a/res/css/structures/_BackdropPanel.pcss b/res/css/structures/_BackdropPanel.pcss index ee2fcf943d5..cb93bd5d6ed 100644 --- a/res/css/structures/_BackdropPanel.pcss +++ b/res/css/structures/_BackdropPanel.pcss @@ -6,6 +6,7 @@ Please see LICENSE files in the repository root for full details. */ .mx_BackdropPanel { + display: none; position: absolute; left: 0; top: 0; From ba8ad14caa0441799f2a788779622edb166360ff Mon Sep 17 00:00:00 2001 From: hazzuk Date: Fri, 13 Dec 2024 13:19:24 +0000 Subject: [PATCH 09/11] feat(leftpanel): reduce default panel width In Element, the default width for the left panel is overly large. --- src/components/structures/LoggedInView.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/structures/LoggedInView.tsx b/src/components/structures/LoggedInView.tsx index 0042169f45c..f9bc5b34100 100644 --- a/src/components/structures/LoggedInView.tsx +++ b/src/components/structures/LoggedInView.tsx @@ -301,7 +301,7 @@ class LoggedInView extends React.Component { private loadResizerPreferences(): void { let lhsSize = parseInt(window.localStorage.getItem("mx_lhs_size")!, 10); if (isNaN(lhsSize)) { - lhsSize = 350; + lhsSize = 204; } this.resizer?.forHandleWithId("lp-resizer")?.resize(lhsSize); } From 8bd2b71acd6e901fc5b320dad0459dda544711d6 Mon Sep 17 00:00:00 2001 From: hazzuk Date: Fri, 13 Dec 2024 13:20:56 +0000 Subject: [PATCH 10/11] feat(font): increase default font size In Element, the default font size is based on the browser default size. But is set at a value of 16, the ideal size is 18. --- config.json | 1 - src/settings/watchers/FontWatcher.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/config.json b/config.json index f7a72ebc799..552dcc60469 100644 --- a/config.json +++ b/config.json @@ -38,7 +38,6 @@ "privacy_policy_url": "https://element.io/cookie-policy", "setting_defaults": { "RustCrypto.staged_rollout_percent": 100, - "baseFontSizeV2": "18", "use_system_theme": false, "showRedactions": false, "showTwelveHourTimestamps": true, diff --git a/src/settings/watchers/FontWatcher.ts b/src/settings/watchers/FontWatcher.ts index 64a6a27f581..c2e71956b6d 100644 --- a/src/settings/watchers/FontWatcher.ts +++ b/src/settings/watchers/FontWatcher.ts @@ -26,7 +26,7 @@ export class FontWatcher implements IWatcher { /** * Default delta added to the ${@link DEFAULT_SIZE} */ - public static readonly DEFAULT_DELTA = 0; + public static readonly DEFAULT_DELTA = 2; private dispatcherRef?: string; From 9772db8bd65735aa3df5c9a355d7d57a49aa6b6c Mon Sep 17 00:00:00 2001 From: hazzuk Date: Fri, 13 Dec 2024 13:40:42 +0000 Subject: [PATCH 11/11] fix(i18n): shorten server description Prevent text overflow with font size increase. --- src/i18n/strings/en_EN.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index f2ad5ce7ac2..49f82a62ec1 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -318,7 +318,7 @@ "reset_password_title": "Reset your password", "server_picker_custom": "Other homeserver", "server_picker_description": "You can use the custom server options to sign into other Matrix servers by specifying a different homeserver URL. This allows you to use %(brand)s with an existing Matrix account on a different homeserver.", - "server_picker_description_matrix.org": "Join millions for free on the largest public server", + "server_picker_description_matrix.org": "Join for free on the largest public server", "server_picker_dialog_title": "Decide where your account is hosted", "server_picker_explainer": "Use your preferred Matrix homeserver if you have one, or host your own.", "server_picker_failed_validate_homeserver": "Unable to validate homeserver",