Skip to content

[ResponseOps][Connectors] Support for OpenAI Connector UI to support URL without dots #217815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Apr 10, 2025

Closes #202423

Summary

This PR updates the URL validation logic in the UI to allow hostnames without a dot character. This brings the UI behavior in line with the API, which already accepts such URLs.

Screenshot 2025-04-14 at 13 53 48

@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Apr 14, 2025
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:version Backport to applied version labels v9.1.0 v8.19.0 enhancement New value added to drive a business result labels Apr 14, 2025
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review April 15, 2025 06:28
@georgianaonoleata1904 georgianaonoleata1904 requested review from a team as code owners April 15, 2025 06:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit skeptical about configuring the form lib to allow domains without dots. We can either create our custom URL validator (using the URL class) or the form lib supports out of the box without any configuration. I would love to hear the opinion of the @elastic/kibana-management team.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 607.0KB 607.1KB +78.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 88.4KB 88.4KB +53.0B
triggersActionsUi 100.0KB 100.2KB +211.0B
total +264.0B

History

cc @georgianaonoleata1904

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowner changes lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OpenAI Connector UI to support URL without dots
4 participants