-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[ResponseOps][Connectors] Support for OpenAI Connector UI to support URL without dots #217815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ResponseOps][Connectors] Support for OpenAI Connector UI to support URL without dots #217815
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit skeptical about configuring the form lib to allow domains without dots. We can either create our custom URL validator (using the URL
class) or the form lib supports out of the box without any configuration. I would love to hear the opinion of the @elastic/kibana-management team.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeowner changes lgtm
Closes #202423
Summary
This PR updates the URL validation logic in the UI to allow hostnames without a dot character. This brings the UI behavior in line with the API, which already accepts such URLs.