[8.x] [ResponseOps][Rules] Ignore unknowns in the schema of the log threshold params (#217440) #217526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld params (elastic#217440) ## Summary A PR introduced into 8.18/9.0 (elastic#205507) changed the way we validate the log threshold rule type parameters. The validation happens on rule params and changes a loose validation to a strict validation, so those users who’ve inserted excess fields before 8.18/9.0 will see rules starting to fail to run, their rule page failing to load and the API starting to reject calls with excess fields. Fixes: elastic#217384 ## Testing instructions 1. Start Kibana on 8.17 and create the following rule using the API. Let the rule run. <details><summary>Rule</summary> ``` { "name": "[QAF] Observability rule 3", "tags": [ "metrics", "threshold", "qaf" ], "rule_type_id": "logs.alert.document.count", "consumer": "alerts", "schedule": { "interval": "1m" }, "actions": [], "params": { "timeSize": 8, "timeUnit": "h", "count": { "value": 1, "comparator": "more than" }, "criteria": [ { "field": "bytes", "comparator": "more than", "value": 1 } ], "logView": { "logViewId": "log-view-reference-0", "type": "log-view-reference" }, "groupBy": [ "geo.dest" ], "outputIndex": ".alerts-observability.logs.alerts-default" } } ``` </details> 2. Start Kibana on 8.18. Verify that you cannot create the same rule and the rule created in step 1 starts failing. 3. Start Kibana on this PR and that you can create the same rule and the rule created in step 1 is working as expected. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2a01722)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @cnasikas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation